Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add import tx method #6132

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

SWvheerden
Copy link
Collaborator

Description

Allows users to import an exported transaction to their wallet.

Motivation and Context

This allows true cold mining. A wallet can export any transaction, and it can then be imported to any transaction which will monitor and ensure the transaction is broadcasted to the network.

How Has This Been Tested?

unit tests and manual

@SWvheerden SWvheerden requested a review from a team as a code owner February 6, 2024 16:22
Copy link

github-actions bot commented Feb 6, 2024

Test Results (CI)

1 270 tests   1 270 ✅  16m 57s ⏱️
   39 suites      0 💤
    1 files        0 ❌

Results for commit 915f54e.

@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Feb 6, 2024
Copy link

github-actions bot commented Feb 6, 2024

Test Results (Integration tests)

 2 files  11 suites   12m 27s ⏱️
29 tests 28 ✅ 0 💤 1 ❌
30 runs  29 ✅ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit 915f54e.

Copy link
Contributor

@hansieodendaal hansieodendaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@ghpbot-tari-project ghpbot-tari-project removed the P-reviews_required Process - Requires a review from a lead maintainer to be merged label Feb 7, 2024
Copy link
Contributor

@brianp brianp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will a file only ever represent a single tx. Would it be trivial to expand the code to support a file with multiple tx's?

@@ -501,6 +502,8 @@ mod test {

export-tx 123456789 --output-file pie.txt

import-tx --input-file pie_this_message.txt
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the significance of pie

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea...
Its a random word I use

@SWvheerden
Copy link
Collaborator Author

So the export code only currently supports exporting a single tx.
But the import of transactions can be multiple.
Look the load_tx_from_csv_file function, it steps through the json file and tries to find all transactions it can

@SWvheerden SWvheerden merged commit f3d9121 into tari-project:development Feb 8, 2024
12 of 14 checks passed
sdbondi added a commit to sdbondi/tari that referenced this pull request Feb 15, 2024
* development: (120 commits)
  chore: use log4rs 1.3 (tari-project#6148)
  fix: balanced binary merkle tree merged proof (tari-project#6144)
  chore(deps): bump libgit2-sys from 0.16.1+1.7.1 to 0.16.2+1.7.2 (tari-project#6145)
  feat: allow ffi to see lock height (tari-project#6140)
  chore(ci): add metrics targeted build, remove miner artifacts, misc clean ups (tari-project#6141)
  chore: suppress error (tari-project#6137)
  chore: fix versions to correct version (tari-project#6135)
  chore: add stringhandler gpg (tari-project#6134)
  chore: add pgp public key (tari-project#6139)
  feat: turn off node metrics by default (tari-project#6073)
  feat: add import tx method (tari-project#6132)
  chore: update pgp public key (tari-project#6129)
  chore: new testnet release (tari-project#6127)
  chore: update pgp key (tari-project#6128)
  fix(libtor): prevent metrics port conflict (tari-project#6125)
  fix(comms): correctly initialize hidden service (tari-project#6124)
  chore: make MAC equality check more idiomatic (tari-project#6123)
  chore: new release (tari-project#6120)
  fix: restart tx fix (tari-project#6119)
  chore: suppress warn log (tari-project#6118)
  ...
@SWvheerden SWvheerden deleted the sw_input_tx branch February 20, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-acks_required Process - Requires more ACKs or utACKs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants